bug #61 removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie (tinyroy)

nicolas-grekas · nicolas-grekas · commit 8592ca335332 · 2019-03-11T15:59:53.000+01:00
This PR was merged into the 1.2-dev branch. Discussion ---------- removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie Fix #25 Fix #26 Commits ------- dd1111e removed 'Set-Cookie' from header when it is already converted to a Symfony header cookie
diff --git a/Factory/HttpFoundationFactory.php b/Factory/HttpFoundationFactory.php
@@ -140,14 +140,17 @@ protected function getTemporaryPath()
      */
     public function createResponse(ResponseInterface $psrResponse)
     {
+        $cookies = $psrResponse->getHeader('Set-Cookie');
+        $psrResponse = $psrResponse->withHeader('Set-Cookie', array());
+
         $response = new Response(
             $psrResponse->getBody()->__toString(),
             $psrResponse->getStatusCode(),
             $psrResponse->getHeaders()
         );
         $response->setProtocolVersion($psrResponse->getProtocolVersion());
 
-        foreach ($psrResponse->getHeader('Set-Cookie') as $cookie) {
+        foreach ($cookies as $cookie) {
             $response->headers->setCookie($this->createCookie($cookie));
         }
 
diff --git a/Tests/Fixtures/Message.php b/Tests/Fixtures/Message.php
@@ -64,7 +64,9 @@ public function getHeaderLine($name)
 
     public function withHeader($name, $value)
     {
-        throw new \BadMethodCallException('Not implemented.');
+        $this->headers[$name] = (array) $value;
+
+        return $this;
     }
 
     public function withAddedHeader($name, $value)

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,9 @@ public function getHeaderLine($name)`
`64`	`64`
`65`	`65`	`public function withHeader($name, $value)`
`66`	`66`	`{`
`67`		`- throw new \BadMethodCallException('Not implemented.');`
	`67`	`+ $this->headers[$name] = (array) $value;`
	`68`	`+`
	`69`	`+ return $this;`
`68`	`70`	`}`
`69`	`71`
`70`	`72`	`public function withAddedHeader($name, $value)`