feature #9966 added feedback to the cache:clear command (fabpot)

fabpot · fabpot · commit 79bea0a27402 · 2014-01-07T15:24:04.000+01:00
This PR was merged into the 2.5-dev branch. Discussion ---------- added feedback to the cache:clear command simplified version of #9463 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9463 | License | MIT | Doc PR | n/a "Especially in production it is sometimes critical to know exactly when your cache is cleared or warmed up. Currently cache:clear provides no feedback whats however. As sites get bigger, so become their cache files. Removing old cache files may sometimes even take minutes. Without any feedback from the cache:clear you do not know the current status. That's why i added more feedback to the cache:clear command that it makes it possible to see when your cache is warmed up and ready to go." Commits ------- f2261da [FrameworkBundle] simplified code a1f6411 [FrameworkBundle] added feedback in cache:clear
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
@@ -77,9 +77,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $warmupDir = substr($realCacheDir, 0, -1).'_';
 
             if ($filesystem->exists($warmupDir)) {
+                if ($output->isVerbose()) {
+                    $output->writeln('  Clearing outdated warmup directory');
+                }
                 $filesystem->remove($warmupDir);
             }
 
+            if ($output->isVerbose()) {
+                $output->writeln('  Warming up cache');
+            }
             $this->warmup($warmupDir, $realCacheDir, !$input->getOption('no-optional-warmers'));
 
             $filesystem->rename($realCacheDir, $oldCacheDir);
@@ -89,7 +95,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $filesystem->rename($warmupDir, $realCacheDir);
         }
 
+        if ($output->isVerbose()) {
+            $output->writeln('  Removing old cache directory');
+        }
+
         $filesystem->remove($oldCacheDir);
+
+        if ($output->isVerbose()) {
+            $output->writeln('  Done');
+        }
     }
 
     /**
