feature #10257 [FrameworkBundle][Console] Load command from DIC after command from bundles. (lyrixx)

fabpot · fabpot · commit 6e9358a9e9c1 · 2014-02-19T22:48:36.000+01:00
This PR was merged into the 2.5-dev branch. Discussion ---------- [FrameworkBundle][Console] Load command from DIC after command from bundles. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - It's better to load a command from DIC after other one. Because it allow easy override of default (symfony/assetic/doctrine) command. The end user could do: # config.yml services: assetic.command.dump: class: SensioLabs\Shim\Assetic\DumpCommand tags: - { name: console.command } **Note**: This is not a new feature... It could be very cool to have it for symfony 2.4 ;) Commits ------- 34f4ef5 [FrameworkBundle][Console] Load command from DIC after command from bundles.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Application.php b/src/Symfony/Bundle/FrameworkBundle/Console/Application.php
@@ -100,16 +100,16 @@ protected function registerCommands()
     {
         $container = $this->kernel->getContainer();
 
-        if ($container->hasParameter('console.command.ids')) {
-            foreach ($container->getParameter('console.command.ids') as $id) {
-                $this->add($container->get($id));
-            }
-        }
-
         foreach ($this->kernel->getBundles() as $bundle) {
             if ($bundle instanceof Bundle) {
                 $bundle->registerCommands($this);
             }
         }
+
+        if ($container->hasParameter('console.command.ids')) {
+            foreach ($container->getParameter('console.command.ids') as $id) {
+                $this->add($container->get($id));
+            }
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -100,16 +100,16 @@ protected function registerCommands()`
`100`	`100`	`{`
`101`	`101`	`$container = $this->kernel->getContainer();`
`102`	`102`
`103`		`- if ($container->hasParameter('console.command.ids')) {`
`104`		`- foreach ($container->getParameter('console.command.ids') as $id) {`
`105`		`- $this->add($container->get($id));`
`106`		`- }`
`107`		`- }`
`108`		`-`
`109`	`103`	`foreach ($this->kernel->getBundles() as $bundle) {`
`110`	`104`	`if ($bundle instanceof Bundle) {`
`111`	`105`	`$bundle->registerCommands($this);`
`112`	`106`	`}`
`113`	`107`	`}`
	`108`	`+`
	`109`	`+ if ($container->hasParameter('console.command.ids')) {`
	`110`	`+ foreach ($container->getParameter('console.command.ids') as $id) {`
	`111`	`+ $this->add($container->get($id));`
	`112`	`+ }`
	`113`	`+ }`
`114`	`114`	`}`
`115`	`115`	`}`