Added tests.

Drak · Drak · commit 6aec7898e368 · 2011-09-27T15:20:51.000+05:45
diff --git a/src/Symfony/Component/HttpFoundation/ParameterBag.php b/src/Symfony/Component/HttpFoundation/ParameterBag.php
@@ -250,7 +250,7 @@ public function getInt($key, $default = 0, $deep = false)
      * @param mixed   $default Default = null.
      * @param boolean $deep    Default = false.
      * @param integer $filter  FILTER_* constant.
-     * @param array   $options Fitler options.
+     * @param array   $options Filter options - can be an array of options or FILTER_* constant.
      *
      * @return mixed
      */
diff --git a/tests/Symfony/Tests/Component/HttpFoundation/ParameterBagTest.php b/tests/Symfony/Tests/Component/HttpFoundation/ParameterBagTest.php
@@ -162,4 +162,39 @@ public function testGetInt()
         $this->assertEquals(123, $bag->getInt('digits'), '->getInt() gets a value of parameter as integer');
         $this->assertEquals(0, $bag->getInt('unknown'), '->getInt() returns zero if a parameter is not defined');
     }
+    
+    /**
+     * @covers Symfony\Component\HttpFoundation\ParameterBag::filter
+     */
+    public function testFilter()
+    {
+        $bag = new ParameterBag(array(
+            'digits' => '0123ab', 
+            'email' => 'example@example.com', 
+            'url' => 'http://example.com/',
+            'dec' => '256',
+            'hex' => '0x100',
+            'array' => 'bang',
+            ));
+
+        $this->assertEmpty($bag->filter('nokey'), '->filter() should return empty by default if no key is found');
+        
+        $this->assertEquals('0123', $bag->filter('digits', '', false, FILTER_SANITIZE_NUMBER_INT), '->filter() gets a value of parameter as integer filtering out invalid characters');
+        
+        $this->assertEquals('example@example.com', $bag->filter('email', '', false, FILTER_VALIDATE_EMAIL), '->filter() gets a value of parameter as email');
+        
+        $this->assertNotEquals('http://example.com/foo', $bag->filter('url', '', false, FILTER_VALIDATE_URL, array('flags' => FILTER_FLAG_PATH_REQUIRED)), '->filter() gets a value of parameter as url with a path');
+        
+        $this->assertFalse($bag->filter('dec', '', false, FILTER_VALIDATE_INT, array(
+            'flags'   => FILTER_FLAG_ALLOW_HEX,
+            'options' => array('min_range' => 1, 'max_range' => 0xff))
+                ), '->filter() gets a value of parameter as integer between boundaries');
+        
+        $this->assertFalse($bag->filter('hex', '', false, FILTER_VALIDATE_INT, array(
+            'flags'   => FILTER_FLAG_ALLOW_HEX,
+            'options' => array('min_range' => 1, 'max_range' => 0xff))
+                ), '->filter() gets a value of parameter as integer between boundaries');
+        
+        $this->assertNotEquals(array('bang'), $bag->filter('array', '', false), '->filter() gets a value of parameter as an array');
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ public function getInt($key, $default = 0, $deep = false)`
`250`	`250`	`* @param mixed $default Default = null.`
`251`	`251`	`* @param boolean $deep Default = false.`
`252`	`252`	`* @param integer $filter FILTER_* constant.`
`253`		`- * @param array $options Fitler options.`
	`253`	`+ * @param array $options Filter options - can be an array of options or FILTER_* constant.`
`254`	`254`	`*`
`255`	`255`	`* @return mixed`
`256`	`256`	`*/`