[Form] Fixed infinite tests when ICU is available

webmozart · fabpot · commit 61773dea68e2 · 2014-03-30T09:42:25.000+02:00
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php
@@ -433,8 +433,8 @@ public function testDateTypeChoiceErrorsBubbleUp()
 
         $form['date']->addError($error);
 
-        $this->assertSame(array(), $form['date']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     public function testDateTypeSingleTextErrorsBubbleUp()
@@ -446,8 +446,8 @@ public function testDateTypeSingleTextErrorsBubbleUp()
 
         $form['date']->addError($error);
 
-        $this->assertSame(array(), $form['date']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     public function testTimeTypeChoiceErrorsBubbleUp()
@@ -457,8 +457,8 @@ public function testTimeTypeChoiceErrorsBubbleUp()
 
         $form['time']->addError($error);
 
-        $this->assertSame(array(), $form['time']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['time']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     public function testTimeTypeSingleTextErrorsBubbleUp()
@@ -470,8 +470,8 @@ public function testTimeTypeSingleTextErrorsBubbleUp()
 
         $form['time']->addError($error);
 
-        $this->assertSame(array(), $form['time']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['time']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
 }
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
@@ -745,8 +745,8 @@ public function testYearErrorsBubbleUp($widget)
         ));
         $form['year']->addError($error);
 
-        $this->assertSame(array(), $form['year']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['year']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     /**
@@ -760,8 +760,8 @@ public function testMonthErrorsBubbleUp($widget)
         ));
         $form['month']->addError($error);
 
-        $this->assertSame(array(), $form['month']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['month']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     /**
@@ -775,8 +775,8 @@ public function testDayErrorsBubbleUp($widget)
         ));
         $form['day']->addError($error);
 
-        $this->assertSame(array(), $form['day']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['day']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     public function testYearsFor32BitsMachines()
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php
@@ -601,8 +601,8 @@ public function testHourErrorsBubbleUp($widget)
         ));
         $form['hour']->addError($error);
 
-        $this->assertSame(array(), $form['hour']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['hour']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     /**
@@ -616,8 +616,8 @@ public function testMinuteErrorsBubbleUp($widget)
         ));
         $form['minute']->addError($error);
 
-        $this->assertSame(array(), $form['minute']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['minute']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     /**
@@ -632,8 +632,8 @@ public function testSecondErrorsBubbleUp($widget)
         ));
         $form['second']->addError($error);
 
-        $this->assertSame(array(), $form['second']->getErrors());
-        $this->assertSame(array($error), $form->getErrors());
+        $this->assertSame(array(), iterator_to_array($form['second']->getErrors()));
+        $this->assertSame(array($error), iterator_to_array($form->getErrors()));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -433,8 +433,8 @@ public function testDateTypeChoiceErrorsBubbleUp()`
`433`	`433`
`434`	`434`	`$form['date']->addError($error);`
`435`	`435`
`436`		`- $this->assertSame(array(), $form['date']->getErrors());`
`437`		`- $this->assertSame(array($error), $form->getErrors());`
	`436`	`+ $this->assertSame(array(), iterator_to_array($form['date']->getErrors()));`
	`437`	`+ $this->assertSame(array($error), iterator_to_array($form->getErrors()));`
`438`	`438`	`}`
`439`	`439`
`440`	`440`	`public function testDateTypeSingleTextErrorsBubbleUp()`
`@@ -446,8 +446,8 @@ public function testDateTypeSingleTextErrorsBubbleUp()`
`446`	`446`
`447`	`447`	`$form['date']->addError($error);`
`448`	`448`
`449`		`- $this->assertSame(array(), $form['date']->getErrors());`
`450`		`- $this->assertSame(array($error), $form->getErrors());`
	`449`	`+ $this->assertSame(array(), iterator_to_array($form['date']->getErrors()));`
	`450`	`+ $this->assertSame(array($error), iterator_to_array($form->getErrors()));`
`451`	`451`	`}`
`452`	`452`
`453`	`453`	`public function testTimeTypeChoiceErrorsBubbleUp()`
`@@ -457,8 +457,8 @@ public function testTimeTypeChoiceErrorsBubbleUp()`
`457`	`457`
`458`	`458`	`$form['time']->addError($error);`
`459`	`459`
`460`		`- $this->assertSame(array(), $form['time']->getErrors());`
`461`		`- $this->assertSame(array($error), $form->getErrors());`
	`460`	`+ $this->assertSame(array(), iterator_to_array($form['time']->getErrors()));`
	`461`	`+ $this->assertSame(array($error), iterator_to_array($form->getErrors()));`
`462`	`462`	`}`
`463`	`463`
`464`	`464`	`public function testTimeTypeSingleTextErrorsBubbleUp()`
`@@ -470,8 +470,8 @@ public function testTimeTypeSingleTextErrorsBubbleUp()`
`470`	`470`
`471`	`471`	`$form['time']->addError($error);`
`472`	`472`
`473`		`- $this->assertSame(array(), $form['time']->getErrors());`
`474`		`- $this->assertSame(array($error), $form->getErrors());`
	`473`	`+ $this->assertSame(array(), iterator_to_array($form['time']->getErrors()));`
	`474`	`+ $this->assertSame(array($error), iterator_to_array($form->getErrors()));`
`475`	`475`	`}`
`476`	`476`
`477`	`477`	`}`