[FileSystem] verbose error when failing to create symlink in windows due to no administrator-rights

Erik Trapman · Erik Trapman · commit 5879a543b896 · 2012-06-14T10:28:25.000+02:00
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -148,6 +148,8 @@ public function rename($origin, $target)
      * @param string  $originDir     The origin directory path
      * @param string  $targetDir     The symbolic link name
      * @param Boolean $copyOnWindows Whether to copy files if on Windows
+     *
+     * @throws \RuntimeException When creation of symlink raises an error
      */
     public function symlink($originDir, $targetDir, $copyOnWindows = false)
     {
@@ -169,7 +171,14 @@ public function symlink($originDir, $targetDir, $copyOnWindows = false)
         }
 
         if (!$ok) {
-            symlink($originDir, $targetDir);
+            try {
+                symlink($originDir, $targetDir);
+            } catch (\ErrorException $e) {
+                if (defined('PHP_WINDOWS_VERSION_MAJOR') && false !== strpos($e->getMessage(), 'error code(1314)')) {
+                    throw new \RuntimeException("Unable to create symlink due to error code 1314: A required privilege is not held by the client. Do you have the required Administrator-rights?");
+                }
+                throw $e;
+            }
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,8 @@ public function rename($origin, $target)`
`148`	`148`	`* @param string $originDir The origin directory path`
`149`	`149`	`* @param string $targetDir The symbolic link name`
`150`	`150`	`* @param Boolean $copyOnWindows Whether to copy files if on Windows`
	`151`	`+ *`
	`152`	`+ * @throws \RuntimeException When creation of symlink raises an error`
`151`	`153`	`*/`
`152`	`154`	`public function symlink($originDir, $targetDir, $copyOnWindows = false)`
`153`	`155`	`{`
`@@ -169,7 +171,14 @@ public function symlink($originDir, $targetDir, $copyOnWindows = false)`
`169`	`171`	`}`
`170`	`172`
`171`	`173`	`if (!$ok) {`
`172`		`- symlink($originDir, $targetDir);`
	`174`	`+ try {`
	`175`	`+ symlink($originDir, $targetDir);`
	`176`	`+ } catch (\ErrorException $e) {`
	`177`	`+ if (defined('PHP_WINDOWS_VERSION_MAJOR') && false !== strpos($e->getMessage(), 'error code(1314)')) {`
	`178`	`+ throw new \RuntimeException("Unable to create symlink due to error code 1314: A required privilege is not held by the client. Do you have the required Administrator-rights?");`
	`179`	`+ }`
	`180`	`+ throw $e;`
	`181`	`+ }`
`173`	`182`	`}`
`174`	`183`	`}`
`175`	`184`