adds support for PTY mode

schmittjoh · schmittjoh · commit 53441aa3d0d6 · 2013-08-03T09:10:03.000+02:00
diff --git a/src/Symfony/Component/Process/CHANGELOG.md b/src/Symfony/Component/Process/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * added the ability to define an idle timeout
+ * added support for PTY mode
 
 2.3.0
 -----
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -62,6 +62,7 @@ class Process
     private $incrementalOutputOffset;
     private $incrementalErrorOutputOffset;
     private $tty;
+    private $pty;
 
     private $fileHandles;
     private $readBytes;
@@ -156,6 +157,7 @@ public function __construct($commandline, $cwd = null, array $env = null, $stdin
         }
         $this->stdin = $stdin;
         $this->setTimeout($timeout);
+        $this->pty = false;
         $this->enhanceWindowsCompatibility = true;
         $this->enhanceSigchildCompatibility = !defined('PHP_WINDOWS_VERSION_BUILD') && $this->isSigchildEnabled();
         $this->options = array_replace(array('suppress_errors' => true, 'binary_pipes' => true), $options);
@@ -915,6 +917,30 @@ public function isTty()
         return $this->tty;
     }
 
+    /**
+     * Sets PTY mode.
+     *
+     * @param Boolean $bool
+     *
+     * @return self
+     */
+    public function setPty($bool)
+    {
+        $this->pty = (Boolean) $bool;
+
+        return $this;
+    }
+
+    /**
+     * Returns PTY state.
+     *
+     * @return Boolean
+     */
+    public function isPty()
+    {
+        return $this->pty;
+    }
+
     /**
      * Gets the working directory.
      *
@@ -1137,6 +1163,12 @@ private function getDescriptors()
                 array('file', '/dev/tty', 'w'),
                 array('file', '/dev/tty', 'w'),
             );
+        } elseif ($this->pty) {
+            $descriptors = array(
+                array('pty'),
+                array('pty'),
+                array('pty'),
+            );
         } else {
            $descriptors = array(
                 array('pipe', 'r'), // stdin
diff --git a/src/Symfony/Component/Process/Tests/AbstractProcessTest.php b/src/Symfony/Component/Process/Tests/AbstractProcessTest.php
@@ -200,6 +200,23 @@ public function testTTYCommand()
         $this->assertSame(Process::STATUS_TERMINATED, $process->getStatus());
     }
 
+    /**
+     * @group pty
+     */
+    public function testPTYCommand()
+    {
+        if (defined('PHP_WINDOWS_VERSION_BUILD')) {
+            $this->markTestSkipped('Windows does not have PTY support.');
+        }
+
+        $process = $this->getProcess('echo "foo"');
+        $process->setPty(true);
+        $process->run();
+
+        $this->assertSame(Process::STATUS_TERMINATED, $process->getStatus());
+        $this->assertEquals("foo\r\n", $process->getOutput());
+    }
+
     public function testExitCodeText()
     {
         $process = $this->getProcess('');
