Removed all codeCoverageIgnore annotations from the code

stof · stof · commit 4248169e07a1 · 2014-01-02T15:42:17.000+01:00
These annotations are artificially bumping the code coverage. Unreached
code should be reported in the coverage report, even if we cannot reach
100% coverage for some safeguards.
Thus, some places using them were actually testable (and tested) code.
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -97,9 +97,7 @@ public function setMaxRedirects($maxRedirects)
     public function insulate($insulated = true)
     {
         if ($insulated && !class_exists('Symfony\\Component\\Process\\Process')) {
-            // @codeCoverageIgnoreStart
             throw new \RuntimeException('Unable to isolate requests as the Symfony Process Component is not installed.');
-            // @codeCoverageIgnoreEnd
         }
 
         $this->insulated = (Boolean) $insulated;
@@ -378,9 +376,7 @@ abstract protected function doRequest($request);
      */
     protected function getScript($request)
     {
-        // @codeCoverageIgnoreStart
         throw new \LogicException('To insulate requests, you need to override the getScript() method.');
-        // @codeCoverageIgnoreEnd
     }
 
     /**
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -145,9 +145,8 @@ public function run(InputInterface $input = null, OutputInterface $output = null
             if ($exitCode > 255) {
                 $exitCode = 255;
             }
-            // @codeCoverageIgnoreStart
+
             exit($exitCode);
-            // @codeCoverageIgnoreEnd
         }
 
         return $exitCode;
diff --git a/src/Symfony/Component/Console/Input/StringInput.php b/src/Symfony/Component/Console/Input/StringInput.php
@@ -72,9 +72,7 @@ private function tokenize($input)
                 $tokens[] = stripcslashes($match[1]);
             } else {
                 // should never happen
-                // @codeCoverageIgnoreStart
                 throw new \InvalidArgumentException(sprintf('Unable to parse input near "... %s ..."', substr($input, $cursor, 10)));
-                // @codeCoverageIgnoreEnd
             }
 
             $cursor += strlen($match[0]);
diff --git a/src/Symfony/Component/Console/Output/StreamOutput.php b/src/Symfony/Component/Console/Output/StreamOutput.php
@@ -75,10 +75,8 @@ public function getStream()
     protected function doWrite($message, $newline)
     {
         if (false === @fwrite($this->stream, $message.($newline ? PHP_EOL : ''))) {
-            // @codeCoverageIgnoreStart
             // should never happen
             throw new \RuntimeException('Unable to write output.');
-            // @codeCoverageIgnoreEnd
         }
 
         fflush($this->stream);
@@ -96,12 +94,10 @@ protected function doWrite($message, $newline)
      */
     protected function hasColorSupport()
     {
-        // @codeCoverageIgnoreStart
         if (DIRECTORY_SEPARATOR == '\\') {
             return false !== getenv('ANSICON') || 'ON' === getenv('ConEmuANSI');
         }
 
         return function_exists('posix_isatty') && @posix_isatty($this->stream);
-        // @codeCoverageIgnoreEnd
     }
 }
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -627,9 +627,7 @@ public function filterXPath($xpath)
     public function filter($selector)
     {
         if (!class_exists('Symfony\\Component\\CssSelector\\CssSelector')) {
-            // @codeCoverageIgnoreStart
             throw new \RuntimeException('Unable to filter with a CSS selector as the Symfony CssSelector is not installed (you can use filterXPath instead).');
-            // @codeCoverageIgnoreEnd
         }
 
         return $this->filterXPath(CssSelector::toXPath($selector));
@@ -813,11 +811,9 @@ public function getNode($position)
             if ($i == $position) {
                 return $node;
             }
-        // @codeCoverageIgnoreStart
         }
 
         return null;
-        // @codeCoverageIgnoreEnd
     }
 
     /**
diff --git a/src/Symfony/Component/Translation/PluralizationRules.php b/src/Symfony/Component/Translation/PluralizationRules.php
@@ -18,7 +18,6 @@
  */
 class PluralizationRules
 {
-    // @codeCoverageIgnoreStart
     private static $rules = array();
 
     /**
@@ -212,6 +211,4 @@ public static function set($rule, $locale)
 
         self::$rules[$locale] = $rule;
     }
-
-    // @codeCoverageIgnoreEnd
 }

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,7 @@ public function setMaxRedirects($maxRedirects)`
`97`	`97`	`public function insulate($insulated = true)`
`98`	`98`	`{`
`99`	`99`	`if ($insulated && !class_exists('Symfony\\Component\\Process\\Process')) {`
`100`		`- // @codeCoverageIgnoreStart`
`101`	`100`	`throw new \RuntimeException('Unable to isolate requests as the Symfony Process Component is not installed.');`
`102`		`- // @codeCoverageIgnoreEnd`
`103`	`101`	`}`
`104`	`102`
`105`	`103`	`$this->insulated = (Boolean) $insulated;`
`@@ -378,9 +376,7 @@ abstract protected function doRequest($request);`
`378`	`376`	`*/`
`379`	`377`	`protected function getScript($request)`
`380`	`378`	`{`
`381`		`- // @codeCoverageIgnoreStart`
`382`	`379`	`throw new \LogicException('To insulate requests, you need to override the getScript() method.');`
`383`		`- // @codeCoverageIgnoreEnd`
`384`	`380`	`}`
`385`	`381`
`386`	`382`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,8 @@ public function run(InputInterface $input = null, OutputInterface $output = null`
`145`	`145`	`if ($exitCode > 255) {`
`146`	`146`	`$exitCode = 255;`
`147`	`147`	`}`
`148`		`- // @codeCoverageIgnoreStart`
	`148`	`+`
`149`	`149`	`exit($exitCode);`
`150`		`- // @codeCoverageIgnoreEnd`
`151`	`150`	`}`
`152`	`151`
`153`	`152`	`return $exitCode;`
Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,7 @@ private function tokenize($input)`
`72`	`72`	`$tokens[] = stripcslashes($match[1]);`
`73`	`73`	`} else {`
`74`	`74`	`// should never happen`
`75`		`- // @codeCoverageIgnoreStart`
`76`	`75`	`throw new \InvalidArgumentException(sprintf('Unable to parse input near "... %s ..."', substr($input, $cursor, 10)));`
`77`		`- // @codeCoverageIgnoreEnd`
`78`	`76`	`}`
`79`	`77`
`80`	`78`	`$cursor += strlen($match[0]);`
Original file line number	Diff line number	Diff line change
`@@ -75,10 +75,8 @@ public function getStream()`
`75`	`75`	`protected function doWrite($message, $newline)`
`76`	`76`	`{`
`77`	`77`	`if (false === @fwrite($this->stream, $message.($newline ? PHP_EOL : ''))) {`
`78`		`- // @codeCoverageIgnoreStart`
`79`	`78`	`// should never happen`
`80`	`79`	`throw new \RuntimeException('Unable to write output.');`
`81`		`- // @codeCoverageIgnoreEnd`
`82`	`80`	`}`
`83`	`81`
`84`	`82`	`fflush($this->stream);`
`@@ -96,12 +94,10 @@ protected function doWrite($message, $newline)`
`96`	`94`	`*/`
`97`	`95`	`protected function hasColorSupport()`
`98`	`96`	`{`
`99`		`- // @codeCoverageIgnoreStart`
`100`	`97`	`if (DIRECTORY_SEPARATOR == '\\') {`
`101`	`98`	`return false !== getenv('ANSICON') \|\| 'ON' === getenv('ConEmuANSI');`
`102`	`99`	`}`
`103`	`100`
`104`	`101`	`return function_exists('posix_isatty') && @posix_isatty($this->stream);`
`105`		`- // @codeCoverageIgnoreEnd`
`106`	`102`	`}`
`107`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -627,9 +627,7 @@ public function filterXPath($xpath)`
`627`	`627`	`public function filter($selector)`
`628`	`628`	`{`
`629`	`629`	`if (!class_exists('Symfony\\Component\\CssSelector\\CssSelector')) {`
`630`		`- // @codeCoverageIgnoreStart`
`631`	`630`	`throw new \RuntimeException('Unable to filter with a CSS selector as the Symfony CssSelector is not installed (you can use filterXPath instead).');`
`632`		`- // @codeCoverageIgnoreEnd`
`633`	`631`	`}`
`634`	`632`
`635`	`633`	`return $this->filterXPath(CssSelector::toXPath($selector));`
`@@ -813,11 +811,9 @@ public function getNode($position)`
`813`	`811`	`if ($i == $position) {`
`814`	`812`	`return $node;`
`815`	`813`	`}`
`816`		`- // @codeCoverageIgnoreStart`
`817`	`814`	`}`
`818`	`815`
`819`	`816`	`return null;`
`820`		`- // @codeCoverageIgnoreEnd`
`821`	`817`	`}`
`822`	`818`
`823`	`819`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`*/`
`19`	`19`	`class PluralizationRules`
`20`	`20`	`{`
`21`		`- // @codeCoverageIgnoreStart`
`22`	`21`	`private static $rules = array();`
`23`	`22`
`24`	`23`	`/**`
`@@ -212,6 +211,4 @@ public static function set($rule, $locale)`
`212`	`211`
`213`	`212`	`self::$rules[$locale] = $rule;`
`214`	`213`	`}`
`215`		`-`
`216`		`- // @codeCoverageIgnoreEnd`
`217`	`214`	`}`