[Dotenv] Fix reading config for symfony/runtime when running dump command

nicolas-grekas · nicolas-grekas · commit 376abbe73c0f · 2022-02-15T18:04:12.000+01:00
diff --git a/src/Symfony/Component/Dotenv/Command/DotenvDumpCommand.php b/src/Symfony/Component/Dotenv/Command/DotenvDumpCommand.php
@@ -24,18 +24,18 @@
  *
  * @internal
  */
-#[Autoconfigure(bind: ['$dotenvPath' => '%kernel.project_dir%/.env', '$defaultEnv' => '%kernel.environment%'])]
+#[Autoconfigure(bind: ['$projectDir' => '%kernel.project_dir%', '$defaultEnv' => '%kernel.environment%'])]
 final class DotenvDumpCommand extends Command
 {
     protected static $defaultName = 'dotenv:dump';
     protected static $defaultDescription = 'Compiles .env files to .env.local.php';
 
-    private $dotenvPath;
+    private $projectDir;
     private $defaultEnv;
 
-    public function __construct(string $dotenvPath, string $defaultEnv = null)
+    public function __construct(string $projectDir, string $defaultEnv = null)
     {
-        $this->dotenvPath = $dotenvPath;
+        $this->projectDir = $projectDir;
         $this->defaultEnv = $defaultEnv;
 
         parent::__construct();
@@ -65,13 +65,23 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
+        $config = [];
+        if (is_file($projectDir = $this->projectDir)) {
+            $config = ['dotenv_path' => basename($projectDir)];
+            $projectDir = \dirname($projectDir);
+        }
+
+        $composerFile = $projectDir.'/composer.json';
+        $config += (is_file($composerFile) ? json_decode(file_get_contents($composerFile), true) : [])['extra']['runtime'] ?? [];
+        $dotenvPath = $projectDir.'/'.($config['dotenv_path'] ?? '.env');
         $env = $input->getArgument('env') ?? $this->defaultEnv;
+        $envKey = $config['env_var_name'] ?? 'APP_ENV';
 
         if ($input->getOption('empty')) {
-            $vars = ['APP_ENV' => $env];
+            $vars = [$envKey => $env];
         } else {
-            $vars = $this->loadEnv($env);
-            $env = $vars['APP_ENV'];
+            $vars = $this->loadEnv($dotenvPath, $env, $config);
+            $env = $vars[$envKey];
         }
 
         $vars = var_export($vars, true);
@@ -83,26 +93,26 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 return $vars;
 
 EOF;
-        file_put_contents($this->dotenvPath.'.local.php', $vars, \LOCK_EX);
+        file_put_contents($dotenvPath.'.local.php', $vars, \LOCK_EX);
 
         $output->writeln(sprintf('Successfully dumped .env files in <info>.env.local.php</> for the <info>%s</> environment.', $env));
 
         return 0;
     }
 
-    private function loadEnv(string $env): array
+    private function loadEnv(string $dotenvPath, string $env, array $config): array
     {
         $dotenv = new Dotenv();
-        $composerFile = \dirname($this->dotenvPath).'/composer.json';
-        $testEnvs = (is_file($composerFile) ? json_decode(file_get_contents($composerFile), true) : [])['extra']['runtime']['test_envs'] ?? ['test'];
+        $envKey = $config['env_var_name'] ?? 'APP_ENV';
+        $testEnvs = $config['test_envs'] ?? ['test'];
 
         $globalsBackup = [$_SERVER, $_ENV];
-        unset($_SERVER['APP_ENV']);
-        $_ENV = ['APP_ENV' => $env];
+        unset($_SERVER[$envKey]);
+        $_ENV = [$envKey => $env];
         $_SERVER['SYMFONY_DOTENV_VARS'] = implode(',', array_keys($_SERVER));
 
         try {
-            $dotenv->loadEnv($this->dotenvPath, null, 'dev', $testEnvs);
+            $dotenv->loadEnv($dotenvPath, null, 'dev', $testEnvs);
             unset($_ENV['SYMFONY_DOTENV_VARS']);
 
             return $_ENV;
diff --git a/src/Symfony/Component/Dotenv/Tests/Command/DotenvDumpCommandTest.php b/src/Symfony/Component/Dotenv/Tests/Command/DotenvDumpCommandTest.php
@@ -95,7 +95,7 @@ public function testExecuteTestEnvs()
     private function createCommand(): CommandTester
     {
         $application = new Application();
-        $application->add(new DotenvDumpCommand(__DIR__.'/.env'));
+        $application->add(new DotenvDumpCommand(__DIR__));
 
         return new CommandTester($application->find('dotenv:dump'));
     }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public function testExecuteTestEnvs()`
`95`	`95`	`private function createCommand(): CommandTester`
`96`	`96`	`{`
`97`	`97`	`$application = new Application();`
`98`		`- $application->add(new DotenvDumpCommand(__DIR__.'/.env'));`
	`98`	`+ $application->add(new DotenvDumpCommand(__DIR__));`
`99`	`99`
`100`	`100`	`return new CommandTester($application->find('dotenv:dump'));`
`101`	`101`	`}`