[Validator] Throw exception if ObjectInitializer is constructed without visitors

webmozart · webmozart · commit 321d5bb30a37 · 2014-03-30T18:28:54.000+02:00
diff --git a/src/Symfony/Component/Validator/NodeVisitor/ObjectInitializer.php b/src/Symfony/Component/Validator/NodeVisitor/ObjectInitializer.php
@@ -30,10 +30,15 @@ public function __construct(array $initializers)
     {
         foreach ($initializers as $initializer) {
             if (!$initializer instanceof ObjectInitializerInterface) {
-                throw new \LogicException('Validator initializers must implement ObjectInitializerInterface.');
+                throw new \InvalidArgumentException('Validator initializers must implement ObjectInitializerInterface.');
             }
         }
 
+        // If no initializer is present, this visitor should not even be created
+        if (0 === count($initializers)) {
+            throw new \InvalidArgumentException('Please pass at least one initializer.');
+        }
+
         $this->initializers = $initializers;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,15 @@ public function __construct(array $initializers)`
`30`	`30`	`{`
`31`	`31`	`foreach ($initializers as $initializer) {`
`32`	`32`	`if (!$initializer instanceof ObjectInitializerInterface) {`
`33`		`- throw new \LogicException('Validator initializers must implement ObjectInitializerInterface.');`
	`33`	`+ throw new \InvalidArgumentException('Validator initializers must implement ObjectInitializerInterface.');`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`
	`37`	`+ // If no initializer is present, this visitor should not even be created`
	`38`	`+ if (0 === count($initializers)) {`
	`39`	`+ throw new \InvalidArgumentException('Please pass at least one initializer.');`
	`40`	`+ }`
	`41`	`+`
`37`	`42`	`$this->initializers = $initializers;`
`38`	`43`	`}`
`39`	`44`