feature #9843 [PropertyAccess] Allowed non alphanumeric chars in object properties (florianv)

fabpot · fabpot · commit 2b7af1245ebc · 2013-12-23T16:28:54.000+01:00
This PR was merged into the 2.5-dev branch. Discussion ---------- [PropertyAccess] Allowed non alphanumeric chars in object properties | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #8930 | License | MIT | Doc PR | Commits ------- 20d4eb6 [PropertyAccess] Allowed non alphanumeric chars in object properties
diff --git a/src/Symfony/Component/PropertyAccess/CHANGELOG.md b/src/Symfony/Component/PropertyAccess/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+2.5.0
+------
+
+ * allowed non alpha numeric characters in second level and deeper object properties names
+
 2.3.0
 ------
 
diff --git a/src/Symfony/Component/PropertyAccess/PropertyPath.php b/src/Symfony/Component/PropertyAccess/PropertyPath.php
@@ -118,7 +118,7 @@ public function __construct($propertyPath)
 
             $position += strlen($matches[1]);
             $remaining = $matches[4];
-            $pattern = '/^(\.(\w+)|\[([^\]]+)\])(.*)/';
+            $pattern = '/^(\.([^\.|\[]+)|\[([^\]]+)\])(.*)/';
         }
 
         if ('' !== $remaining) {
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -137,6 +137,13 @@ public function testGetValueReadsPropertyWithSpecialCharsExceptDot()
         $this->assertEquals('Bernhard', $this->getPropertyAccessor()->getValue($array, '%!@$§'));
     }
 
+    public function testGetValueReadsPropertyWithSpecialCharsExceptDotNested()
+    {
+        $object = (object) array('nested' => (object) array('@child' => 'foo'));
+
+        $this->assertEquals('foo', $this->getPropertyAccessor()->getValue($object, 'nested.@child'));
+    }
+
     public function testGetValueReadsPropertyWithCustomPropertyPath()
     {
         $object = new Author();
@@ -328,6 +335,17 @@ public function testSetValueCamelizesSetterNames()
         $this->assertEquals('Schussek', $object->getLastName());
     }
 
+    public function testSetValueWithSpecialCharsNested()
+    {
+        $object = new \stdClass();
+        $person = new \stdClass();
+        $person->{'@email'} = null;
+        $object->person = $person;
+
+        $this->getPropertyAccessor()->setValue($object, 'person.@email', 'bar');
+        $this->assertEquals('bar', $object->person->{'@email'});
+    }
+
     /**
      * @expectedException \Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException
      */
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyPathTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyPathTest.php
@@ -38,12 +38,26 @@ public function testDotCannotBePresentAtTheBeginning()
         new PropertyPath('.property');
     }
 
+    public function providePathsContainingUnexpectedCharacters()
+    {
+        return array(
+            array('property.'),
+            array('property.['),
+            array('property..'),
+            array('property['),
+            array('property[['),
+            array('property[.'),
+            array('property[]'),
+        );
+    }
+
     /**
+     * @dataProvider providePathsContainingUnexpectedCharacters
      * @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
      */
-    public function testUnexpectedCharacters()
+    public function testUnexpectedCharacters($path)
     {
-        new PropertyPath('property.$foo');
+        new PropertyPath($path);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ public function __construct($propertyPath)`
`118`	`118`
`119`	`119`	`$position += strlen($matches[1]);`
`120`	`120`	`$remaining = $matches[4];`
`121`		`- $pattern = '/^(\.(\w+)\|\[([^\]]+)\])(.*)/';`
	`121`	`+ $pattern = '/^(\.([^\.\|\[]+)\|\[([^\]]+)\])(.*)/';`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`if ('' !== $remaining) {`