Drop support for Symfony 3 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/drop-symfony-3
branch
from
31d4c70 to
526417d
Compare
Member
Author
|
|
derrabus
force-pushed
the
improvement/drop-symfony-3
branch
3 times, most recently
from
064476e to
39b4eaf
Compare
Contributor
|
Would it be an option to first release a minor with the dbal 2.13 compatibility fixes? And have this PR included in the next minor? |
derrabus
force-pushed
the
improvement/drop-symfony-3
branch
from
39b4eaf to
dcf17ad
Compare
acrobat
reviewed
Apr 28, 2021
acrobat
approved these changes
Apr 28, 2021
Member
Author
I can tag a patch release for the DBAL compatibility, I suppose. |
Member
Author
|
@acrobat v3.1.2 was tagged. |
Contributor
|
Thanks @derrabus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to perform the version bumps that we've done on https://github.com/symfony/acl-bundle already:
Symfony 3 is EOL and we don't develop features for PHP 7.1 anymore. This would also allow us to drop some compatibility code as well as modernize methods with property type declarations.