Add an AclCache implementation supporting a PSR-6 cache pool #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
commented
Apr 24, 2021
derrabus
reviewed
Apr 25, 2021
derrabus
requested changes
Apr 25, 2021
mbabker
changed the title
Merged
derrabus
added a commit
that referenced
this pull request
Apr 26, 2021
This PR was merged into the 3.x-dev branch. Discussion ---------- Code style fixes When locally running the CS fixer against #72 it picked up a couple of other changes along the way, so this PR corrects those so running the tool should result in zero changes on a fresh clone. I also added its cache file to the gitignore. Commits ------- 8c3a8e7 Code style fixes
derrabus
requested changes
Apr 26, 2021
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Thank you, we're almost there. 🙂
derrabus
approved these changes
Apr 27, 2021
stof
approved these changes
Apr 28, 2021
Member
|
Thanks for your work on this new feature! |
wouterj
added a commit
to symfony/acl-bundle
that referenced
this pull request
Jul 16, 2021
This PR was merged into the 2.x-dev branch. Discussion ---------- Add service definition for PsrAclCache Requires symfony/security-acl#72 This adds the service definition for the new `Symfony\Component\Security\Acl\Domain\PsrAclCache` class added to the component for use as a cache service. Commits ------- a603061 Add service definition for PsrAclCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
doctrine/cachebeing sunsetted, the component should provide a cache implementation that doesn't rely on an effectively deprecated package. This PR adds a cache implementation supporting any PSR-6 cache pool which can be used as a replacement.Closes #76