Skip to content

Conversation

@mbabker
Copy link
Contributor

@mbabker mbabker commented Apr 24, 2021

The generateSql tool looks like it hasn't been updated in any meaningful way since this component was permanently split off from the monorepo and definitely couldn't work in its current state. The tool is updated and the schema updated with DBAL 3.1.

@wouterj wouterj merged commit 0c8f38e into symfony:main Apr 25, 2021
@wouterj
Copy link
Member

wouterj commented Apr 25, 2021

Thank you @mbabker!

$loader->addPrefixes([
'Symfony' => __DIR__.'/../../../../../..',
'Doctrine\\Common' => __DIR__.'/../../../../../../../vendor/doctrine-common/lib',
'Doctrine\\DBAL\\Migrations' => __DIR__.'/../../../../../../../vendor/doctrine-migrations/lib',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not even about the time it was permanently split. It was from the time where we migrated to composer rather than a deps file (these paths are not where composer puts files)

@mbabker mbabker deleted the fix-schema-generator branch April 28, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants