Fix symfony 5.3 security incompatiblity #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you really need this fix? That's an incredibly complex test setup for an EOL Symfony branch. 😕 |
Contributor
Author
|
Hmm yes, I thought 5.3 was still supported but you are right as this was also my feeling that the workflow got more complex. Maybe revert the workflow change but keep the test changes and code fix so the library is compatible? Or bump the version constraint for 3.3.x to `symfony/security-core: "^4.4|^5.4|^6.0"? |
Member
|
I'd be in favor of only merging the second commit and tag a release, if @wouterj agrees. For 3.4 we should make the bump you've suggested. |
acrobat
force-pushed
the
fix-sf53-incompatibility
branch
from
1c3469e to
a0ceb91
Compare
Contributor
Author
|
@derrabus That works for me! I've updated the PR to only include the last commit with the fix. The other can still be viewed here -> acrobat@50f1abe |
derrabus
approved these changes
Feb 14, 2022
acrobat
force-pushed
the
fix-sf53-incompatibility
branch
from
a0ceb91 to
37d5165
Compare
acrobat
force-pushed
the
fix-sf53-incompatibility
branch
from
37d5165 to
94c127b
Compare
Member
|
Thank you @acrobat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #100
The
AuthenticationTrustResolverInterface::isAuthenticatedmethod was only added in symfony 5.4 but theAuthenticatedVoter::PUBLIC_ACCESSconstant was already available in symfony 5.3, this causes an error when using security-acl 3.3.0 with symfony 5.3.xsecurity-acl/Domain/SecurityIdentityRetrievalStrategy.php
Lines 81 to 83 in 04d6fad
The first commit actually refactors the test case because even when executing the tests on symfony 5.3 they still pass as we mocked that class/method. I've also changed some things in the github ci workflow because I wasn't able to get symfony 5.3 dependencies with the
ramsey/composer-installpackages (lowest = install, highest = update but this would cause dev packages in this setup), so I'm not sure if this is the desired setup. Let me know if I need the change anything.The second commit actually fixes the problem (the first commit shows a failing test on symfony 5.3 first)