Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/security-acl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 04d6fad
Choose a base ref
...
head repository: symfony/security-acl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 47af09b
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 14, 2022

  1. Fix symfony 5.3 incompatibility

    @acrobat
    acrobat committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    94c127b View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. bug #106 Fix symfony 5.3 security incompatiblity (acrobat) 

    This PR was merged into the 3.x-dev branch.

Discussion
----------

Fix symfony 5.3 security incompatiblity

Follow up of #100

The `AuthenticationTrustResolverInterface::isAuthenticated` method was only added in symfony 5.4 but the `AuthenticatedVoter::PUBLIC_ACCESS` constant was already available in symfony 5.3, this causes an error when using security-acl 3.3.0 with symfony 5.3.x

https://github.com/symfony/security-acl/blob/04d6fadd671d72ff322e20840e510030753e008a/Domain/SecurityIdentityRetrievalStrategy.php#L81-L83

The first commit actually refactors the test case because even when executing the tests on symfony 5.3 they still pass as we mocked that class/method. I've also changed some things in the github ci workflow because I wasn't able to get symfony 5.3 dependencies with the` ramsey/composer-install` packages (lowest = install, highest = update but this would cause dev packages in this setup), so I'm not sure if this is the desired setup. Let me know if I need the change anything.

The second commit actually fixes the problem (the first commit shows a failing test on symfony 5.3 first)

Commits
-------

94c127b Fix symfony 5.3 incompatibility
    @derrabus
    derrabus committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    47af09b View commit details
    Browse the repository at this point in the history
Loading