fix conversion for https requests #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 13, 2020
Member
|
Thank you @4rthem. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 25, 2020
…ory (mleczakm) This PR was merged into the 2.0-dev branch. Discussion ---------- Fix populating default port and headers in HttpFoundationFactory These are few dirty hacks which are required to get symfony up and running as Roadrunner psr7 worker: - overriding headers need to be removed to be able to send basic auth headers. - setting `$_SERVER['https']` to true is required for properly handling non-proxied requests, handled with encryption directly from Roadrunner - same as #77 - setting default server port fixes error with interpreting no port defined in url as `0` Commits ------- 4f30401 Fix populating default port and headers in HttpFoundationFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS requests were not correctly converted.