Skip to content

Fix tags list to use consecutive keys #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GromNaN merged 1 commit into from
Dec 7, 2025
Merged

Fix tags list to use consecutive keys #563

GromNaN merged 1 commit into from
Dec 7, 2025

Conversation

@GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 7, 2025

Q A
Branch? 3.x
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Workaround a bug introduced in symfony/symfony#62329
The Symfony code incorrectly assumes that the tags array is a list. But we use array_filter which leaves gaps in the array keys. Fixed here by using array_values to reset the keys.

Fix failing job:

There were 3 errors:

1) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with app channel" (array(array(), array('app')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%')), array('pushProcessor', array(Symfony\Component\DependencyInjection\Reference Object (...)))), array())
Undefined array key 0

/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86
/home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820
/home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119

2) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with my_channel channel" (array(array(), array('my_channel')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%'))), array(array('pushProcessor', array(Symfony\Component\DependencyInjection\Reference Object (...)))))
Undefined array key 0

/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86
/home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820
/home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119

3) Symfony\Bundle\MonologBundle\Tests\DependencyInjection\Compiler\AddProcessorsPassTest::testEmptyTagsAreIgnoredWhenNonEmptyArePresent with data set "with method and no channel" (array(array(), array('foo')), array(array('useMicrosecondTimestamps', array('%monolog.use_microseconds%')), array('pushProcessor', array(array(Symfony\Component\DependencyInjection\Reference Object (...), 'foo')))), array(array('pushProcessor', array(array(Symfony\Component\DependencyInjection\Reference Object (...), 'foo')))))
Undefined array key 0

/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/PriorityTaggedServiceTrait.php:86
/home/runner/work/monolog-bundle/monolog-bundle/src/DependencyInjection/Compiler/AddProcessorsPass.php:55
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
/home/runner/work/monolog-bundle/monolog-bundle/vendor/symfony/dependency-injection/ContainerBuilder.php:820
/home/runner/work/monolog-bundle/monolog-bundle/tests/DependencyInjection/Compiler/AddProcessorsPassTest.php:119

@GromNaN
Fix tags must be a list
2127520 
Workaround a bug introduced in symfony/symfony#62329
@GromNaN GromNaN added the Bug label Dec 7, 2025
@GromNaN GromNaN changed the title Fix tags must be a list Fix tags list to use consecutive keys Dec 7, 2025
This was referenced Dec 7, 2025
Closed
Merged
@GromNaN GromNaN requested a review from HypeMC December 7, 2025 21:33
@GromNaN GromNaN merged commit 344f262 into symfony:3.x Dec 7, 2025
9 checks passed
@GromNaN GromNaN deleted the fix-tags-index branch December 7, 2025 22:52
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Dec 8, 2025
@nicolas-grekas
bug #62685 [DependencyInjection] Fix PriorityTaggedServiceTrait whe…
16389f6 
…n tag attributes are not a list (GromNaN)

This PR was merged into the 7.3 branch.

Discussion
----------

[DependencyInjection] Fix `PriorityTaggedServiceTrait` when tag attributes are not a list

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Alternative to #62683

Ensure the attributes of the tag are in a list before iterating on them using sequential indexes.

> In symfony/monolog-bundle#485, the tag attributes are filtered, which generates gaps in the keys. The PR mentioned above causes MonologBundle to fail. This can be fixed by symfony/monolog-bundle#563. However I believe the issue should also be addressed in Symfony.

Commits
-------

5a4a036 [DependencyInjection] Fix PriorityTaggedServiceTrait when tag attributes are not a list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HypeMC HypeMC HypeMC approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GromNaN @HypeMC