Remove array_reverse function in x-forwarded-for ip address list#71
Remove array_reverse function in x-forwarded-for ip address list#71om3rcitak wants to merge 1 commit intosymfony:5.3from
array_reverse function in x-forwarded-for ip address list#71Conversation
Who suggest the "we should reverse x-forwarded-for ip addresses list" idea and who accepted this i don't know but this behavior is wrong. Client ip address is first one of x-forwarded-for ip address list and if there is a 1 or multiple gateway between client and server, gateway ip addresses are added last of array. References: - https://en.wikipedia.org/wiki/X-Forwarded-For - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For
|
Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/symfony/symfony Thank you for your contribution! PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply. |
|
@om3rcitak please send this PR to https://github.com/symfony/symfony, this repository is read-only sub-split. |
2 participants
Who suggest the "we should reverse x-forwarded-for ip addresses list" idea and who accepted this i don't know but this behavior is wrong. Client ip address is first one of x-forwarded-for ip address list and if there is a 1 or multiple gateway between client and server, gateway ip addresses are added last of array.
References: