Skip to content

Remove redundant function call #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
javiereguiluz merged 1 commit into from
Mar 28, 2015
Merged

Remove redundant function call #16

javiereguiluz merged 1 commit into from
Mar 28, 2015

Conversation

@wouterj
Copy link
Member

@wouterj wouterj commented Mar 28, 2015

After #15, the inner trim() call is no longer required as the outer one already trims all dashes.

@javiereguiluz
Copy link
Member

javiereguiluz commented Mar 28, 2015

@wouterj thanks for this quick win!

@javiereguiluz javiereguiluz merged commit 22ee7c5 into symfony:master Mar 28, 2015
javiereguiluz added a commit that referenced this pull request Mar 28, 2015
@javiereguiluz
minor #16 Remove redundant function call (WouterJ)
1bca7b3 
This PR was merged into the master branch.

Discussion
----------

Remove redundant function call

After #15, the inner `trim()` call is no longer required as the outer one already trims all dashes.

Commits
-------

22ee7c5 Remove redundant function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wouterj @javiereguiluz