chore: bump golangci-lint to v1.60#383
Merged
tri-adam merged 3 commits intosylabs:mainfrom Aug 23, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 65.42% 65.35% -0.07%
==========================================
Files 37 37
Lines 3248 3259 +11
==========================================
+ Hits 2125 2130 +5
- Misses 971 975 +4
- Partials 152 154 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
The linter is failing here with code that passes on v1.59.x. Seems as though this is the same underlying issue as golangci/golangci-lint#4905, which was addressed in golangci/golangci-lint#4907. Looks like this should be addressed in the next release of |
tri-adam
force-pushed
the
golangci-lint-v1.60
branch
from
1b7e347 to
d2a9ddc
Compare
wobito
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
golangci-lintto v1.60. Address lint, and remove deprecated linter.