chore: bump module Go version to 1.21#351
Merged
tri-adam merged 3 commits intosylabs:mainfrom Mar 19, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 65.27% 65.26% -0.01%
==========================================
Files 34 34
Lines 3266 3245 -21
==========================================
- Hits 2132 2118 -14
+ Misses 978 974 -4
+ Partials 156 153 -3 ☔ View full report in Codecov by Sentry. |
tri-adam
force-pushed
the
go-1.22
branch
4 times, most recently
from
6d2721f to
d0b41d2
Compare
wobito
approved these changes
Feb 9, 2024
dtrudg
previously requested changes
Feb 9, 2024
Member
dtrudg
left a comment
dtrudg
left a comment
There was a problem hiding this comment.
Hold an a sec please - need to verify something wrt build that don't have access to Go 1.21 yet.
dtrudg
dismissed
their stale review
Go ahead... we are month after 1.20 sunset, and I don't see movement on EPEL / EL. We shouldn't be beholden to them for extended periods of time.
dtrudg
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump module Go version to v1.21. Use
slicespackage to simplify implementation.