Skip to content

feat: deprecate user package#325

Merged
tri-adam merged 1 commit intosylabs:mainfrom
tri-adam:deprecate-user
Sep 21, 2023
Merged

feat: deprecate user package#325
tri-adam merged 1 commit intosylabs:mainfrom
tri-adam:deprecate-user

Conversation

@tri-adam
Copy link
Member

@tri-adam tri-adam commented Sep 18, 2023

Mark github.com/sylabs/sif/v2/pkg/user package deprecated. Remove experimental mount and unmount commands.

Closes #323

@tri-adam tri-adam self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #325 (96bf85e) into main (cac8e77) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   72.80%   73.01%   +0.21%     
==========================================
  Files          35       31       -4     
  Lines        2956     2920      -36     
==========================================
- Hits         2152     2132      -20     
+ Misses        646      632      -14     
+ Partials      158      156       -2     
Files Changed Coverage Δ
pkg/siftool/siftool.go 91.66% <ø> (-0.84%) ⬇️
pkg/user/mount.go 0.00% <ø> (ø)

@tri-adam tri-adam marked this pull request as ready for review September 20, 2023 17:26
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit 445a707 into sylabs:main Sep 21, 2023
@tri-adam tri-adam deleted the deprecate-user branch September 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate pkg/user package?

2 participants