Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 73.03% 72.78% -0.26%
==========================================
Files 35 35
Lines 2948 2976 +28
==========================================
+ Hits 2153 2166 +13
- Misses 640 650 +10
- Partials 155 160 +5
|
wobito
force-pushed
the
set-metadata
branch
from
f50e8cd to
25bb8eb
Compare
tri-adam
requested changes
Sep 18, 2023
Member
tri-adam
left a comment
tri-adam
left a comment
There was a problem hiding this comment.
This looks great! Just need to fix up the documentation...
Co-authored-by: Adam Hughes <[email protected]>
tri-adam
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for setting metadata on a descriptor