Skip to content

test: sign/verify round trip for high level tests#310

Merged
tri-adam merged 1 commit intosylabs:mainfrom
tri-adam:pgp-test-fix
Jul 11, 2023
Merged

test: sign/verify round trip for high level tests#310
tri-adam merged 1 commit intosylabs:mainfrom
tri-adam:pgp-test-fix

Conversation

@tri-adam
Copy link
Member

@tri-adam tri-adam commented Jul 10, 2023

Switch from using golden file testing for unit tests, to reduce the workload when the data format of the openpgp module we're using changes.

Closes #309

@tri-adam tri-adam self-assigned this Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #310 (875daa9) into main (7a44fab) will not change coverage.
The diff coverage is n/a.

❗ Current head 875daa9 differs from pull request most recent head ebc1105. Consider uploading reports for the commit ebc1105 to get more accurate results

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   72.94%   72.94%           
=======================================
  Files          35       35           
  Lines        2953     2953           
=======================================
  Hits         2154     2154           
  Misses        644      644           
  Partials      155      155           

@tri-adam tri-adam marked this pull request as ready for review July 10, 2023 19:02
Switch from using golden file testing for TestGroupSigner_Sign and
TestSigner_Sign, to reduce the workload when the data format of the
openpgp module we're using changes.
@tri-adam tri-adam merged commit 082fac1 into sylabs:main Jul 11, 2023
@tri-adam tri-adam deleted the pgp-test-fix branch July 11, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrity test fails with latest go-crypto

2 participants