Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 72.67% 72.94% +0.27%
==========================================
Files 35 35
Lines 2953 2953
==========================================
+ Hits 2146 2154 +8
+ Misses 648 644 -4
+ Partials 159 155 -4
|
tri-adam
force-pushed
the
refactor-blob-write
branch
2 times, most recently
from
dd6f8e6 to
af7c554
Compare
Remove OptOCIBlobMetadata, which required caller to explicitly provide the digest of an OCI blob when creating a DescriptorInput. Calculate the digest automatically as the DataOCIRootIndex/DataOCIBlob data is read.
Return v1.Hash type directly instead of string.
tri-adam
force-pushed
the
refactor-blob-write
branch
from
0dfd9ca to
4b7d9de
Compare
wobito
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a few changes related to working with OCI blobs:
OptOCIBlobMetadata. Calculate the digest automatically when the data is read instead.OCIBlobMetadatatoOCIBlobDigest, and have it return av1.Hashinstead ofstring.WithOCIBlobDigest, to easily locate asif.Descriptorusing via GetDescriptor.