Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 72.85% 72.67% -0.19%
==========================================
Files 35 35
Lines 2899 2953 +54
==========================================
+ Hits 2112 2146 +34
- Misses 634 648 +14
- Partials 153 159 +6
|
tri-adam
requested changes
Jun 12, 2023
Member
tri-adam
left a comment
tri-adam
left a comment
There was a problem hiding this comment.
Looks good, a few questions/comments, thank you!
wobito
force-pushed
the
oci-data-types
branch
3 times, most recently
from
78370a3 to
d84c7a5
Compare
tri-adam
requested changes
Jun 13, 2023
Member
tri-adam
left a comment
tri-adam
left a comment
There was a problem hiding this comment.
One more nit, and one that was hidden in the last one, apologies.
wobito
force-pushed
the
oci-data-types
branch
3 times, most recently
from
a434f25 to
5fb8bf0
Compare
tri-adam
approved these changes
Jun 13, 2023
edytuk
pushed a commit
to edytuk/sif
that referenced
this pull request
Jul 27, 2023
* add: oci blob support remove unused string * add: oci root index support * update: address pr requests * add: oci opt test * add: flag formatting * update: opts method to handle a reader Signed-off-by: Edita Kizinevic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new datatypes in supporting #188
OCI.RootIndexwhich allows the specification of the OCI image index to be addedOCI.Blobwhich allows the specification of OCI artifacts to be added (blob, configs, manifests, and other indexes)