Skip to content

Support native-curl hook#3863

Merged
matyhtf merged 57 commits intomasterfrom
curl-native
Nov 28, 2020
Merged

Support native-curl hook#3863
matyhtf merged 57 commits intomasterfrom
curl-native

Conversation

@matyhtf
Copy link
Copy Markdown
Member

@matyhtf matyhtf commented Nov 20, 2020

No description provided.

twose
twose requested changes Nov 20, 2020
View reviewed changes
@twose
Copy link
Copy Markdown
Member

twose commented Nov 20, 2020

是否可以将原先的单测套上循环, 在native模式下再测一次

@matyhtf matyhtf changed the title Support curl-native hook Support native-curl hook Nov 21, 2020
@matyhtf
Copy link
Copy Markdown
Member Author

matyhtf commented Nov 24, 2020 •
edited
Loading

是否可以将原先的单测套上循环, 在native模式下再测一次

不需要，native curl client 大部分逻辑是 curl 完成的，所有选项参数和API的逻辑正确性应该由 libcurl库保证。我们这里的单测应该重新写，覆盖到 interface.cc 本身的关键逻辑。

@matyhtf matyhtf closed this Nov 24, 2020
@matyhtf matyhtf reopened this Nov 24, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2020 •
edited
Loading

Codecov Report

Merging #3863 (c3ca0b0) into master (6a2cafd) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   49.04%   49.01%   -0.03%     
==========================================
  Files          69       69              
  Lines       12858    12859       +1     
==========================================
- Hits         6306     6303       -3     
- Misses       6552     6556       +4
Impacted Files Coverage Δ
src/reactor/base.cc 60.00% <0.00%> (-1.26%) ⬇️
src/reactor/epoll.cc 75.23% <0.00%> (ø)
src/core/base.cc 75.56% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2cafd...c3ca0b0. Read the comment docs.

@matyhtf matyhtf merged commit 3d2def0 into master Nov 28, 2020
@matyhtf matyhtf deleted the curl-native branch November 29, 2020 13:30
@TheNorthMemory TheNorthMemory mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twose twose twose requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matyhtf @twose @huanghantao