[ClangImporter] Hack. Break deserialization cycle with NSErrorPointer on iOS and watchOS.#9726
Merged
Merged
Conversation
Member
|
This is gross :( |
Contributor
|
I think this'll change how we import |
Contributor
|
Sorry, I skipped a step: good working tracking this down! I'm curious about which declaration is causing the cycle too, but that might not be something we can post on GitHub. |
Contributor
|
@swift-ci smoke test |
Contributor
Author
|
Wrote a comment on rdar://problem/32226279 ; let's move discussion there. |
…f throws functions. This breaks a cycle with a function in Foundation, but isn't a complete fix: it will be similarly problematic if a function that can't have the throws conversion is added.
Contributor
Author
|
@swift-ci please smoke test |
jrose-apple
approved these changes
May 19, 2017
Member
|
@huonw please file an SR for the less hacky solution |
Member
|
@jrose-apple should this be nominated for the 4.0 branch? |
Contributor
|
Yes, I think so. |
Member
|
I will nominate this |
Contributor
|
Thanks, Michael! |
Member
|
@jrose-apple Could you or @huonw help me fill in the explanation, scope, and risk? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses rdar://problem/32226279 .
I haven't yet worked out why this is only occurring on iOS and watchOS, and this is completely not the right long-term fix.