[ClangImporter] Handle DeclContexts that may not originate from Clang modules#88115
Draft
oskarwirga wants to merge 1 commit intoswiftlang:mainfrom
Draft
[ClangImporter] Handle DeclContexts that may not originate from Clang modules#88115oskarwirga wants to merge 1 commit intoswiftlang:mainfrom
oskarwirga wants to merge 1 commit intoswiftlang:mainfrom
Conversation
… modules Change cast<ClangModuleUnit> to dyn_cast<ClangModuleUnit> in several places where the DeclContext may not originate from a Clang module. This occurs when Swift-originated methods are re-imported via a generated -Swift.h bridging header. The hard cast crashes when processing these re-imported declarations, which happens more frequently under arm64e due to additional ObjC metadata processing.
oskarwirga
force-pushed
the
arm64e/clangimporter-fix
branch
from
d18a6c1 to
6a01532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
@swift-ci Please smoke test