[6.3][test] Fix building Android tests on Windows toolchain CI (#86694)#86839
Merged
Conversation
…86694) Ever since swiftlang#84574 added Android availability versioning, the Reflection test stopped building for Android unless the API level was in the target triple, so [we hacked that into CMake in that pull](https://github.com/swiftlang/swift/pull/84574/files#diff-e2e2a250882f66d531f2a42c201e013fa2d8be892b2880a32d6596710761f470R2549), but the Windows CI does not pass in `SWIFT_ANDROID_API_LEVEL`, [like `build-script` does](https://github.com/swiftlang/swift/blob/9143271dfdc92053a7b9d95000d9fd60e42413c3/utils/build-script-impl#L1632), so pass it in here.
finagolfin
added
🍒 release cherry pick
Member
Author
|
@swift-ci test |
compnerd
approved these changes
Jan 28, 2026
Member
Author
|
@stephentyrone, need review on this trivial pull, which won't break anything on the Windows CI but gets the Android tests running on it again. |
adrian-prantl
approved these changes
Jan 28, 2026
Member
Author
|
As planned, this got the Android tests running again on the Swift 6.3 Windows CI. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation: Ever since [Android] Add Android as availability platform #84574 added Android availability versioning, the Reflection test stopped building for Android unless the API level was in the target triple, so we hacked that into CMake in that pull, but the Windows CI does not pass in
SWIFT_ANDROID_API_LEVEL, likebuild-scriptdoes, so pass it in here.Scope: Very limited, only affects building the Android tests on the Windows 6.3 toolchain CI
Issues: None
Original PRs: [test] Fix building Android tests on Windows toolchain CI #86694
Risk: None, these Android tests are purely informational and even build failures of the tests are ignored by
build.ps1.Testing: This got the Android tests building and running again on the trunk toolchain CI.
Reviewers: @compnerd
We're seeing the same Android build issue on the 6.3 toolchain CI, so getting this in there too.