Skip to content

utils: temporarily ignore test failure for Android runtimes #80148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
compnerd merged 1 commit into from
Mar 20, 2025
Merged

utils: temporarily ignore test failure for Android runtimes #80148

compnerd merged 1 commit into from
Mar 20, 2025

Conversation

@weliveindetail
Copy link
Member

@weliveindetail weliveindetail commented Mar 19, 2025

Nightly Windows bot is failing due to unexpectedly passing tests for Android runtimes:

Unexpectedly Passed Tests (3):
  Swift(android-aarch64) :: Driver/parseable_output.swift
  Swift(android-aarch64) :: Driver/parseable_output_unicode.swift
  Swift-validation(android-aarch64) :: compiler_crashers_fixed/28795-inprotocol-isrequirementsignaturecomputed-missing-signature.swift

We do already list them in the Windows-specific test overrides and they should be skipped: https://github.com/weliveindetail/swift/blob/117b95498a70526f53fa9b5ba161c820d8bc306a/utils/windows-swift-android-lit-test-overrides.txt#L247-L249

The very same mechanism works well for LLDB, but the Swift test suite doesn't seem to honour the LIT_FILTER_OUT environment variable:
https://github.com/weliveindetail/swift/blob/117b95498a70526f53fa9b5ba161c820d8bc306a/utils/build.ps1#L1679

@weliveindetail weliveindetail requested a review from compnerd March 19, 2025 23:23
@weliveindetail
Copy link
Member Author

weliveindetail commented Mar 19, 2025

@swift-ci please smoke test

This was referenced Mar 19, 2025
Merged
Merged
compnerd
compnerd approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to unblock the nightlies. Could you please file an issue to investigate this?

@compnerd compnerd enabled auto-merge March 19, 2025 23:50
@compnerd compnerd merged commit 8e10b00 into swiftlang:main Mar 20, 2025
3 checks passed
@weliveindetail weliveindetail mentioned this pull request Mar 20, 2025
Open
@weliveindetail weliveindetail deleted the windrd-unblock-nightly branch March 20, 2025 08:45
@weliveindetail
Copy link
Member Author

weliveindetail commented Mar 20, 2025

@compnerd Instead of creating a new one, I modified the ticket linked above, because it has all the history.

@weliveindetail
Copy link
Member Author

weliveindetail commented Mar 20, 2025

Once #80058 is fixed, this PR should be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weliveindetail @compnerd