Skip to content

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jan 8, 2019

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Remove the unused parameter from the build (NFC).
Colocate the target specific library specification.  Inline the single
site use of the place holder ICU_UC and ICU_I18N libraries rather than
trying to create special library processing code for that.
@compnerd
Copy link
Member Author

compnerd commented Jan 8, 2019

CC: @gottesmm @Rostepher

@compnerd
Copy link
Member Author

compnerd commented Jan 8, 2019

@swift-ci please test

@compnerd compnerd merged commit 5282e92 into swiftlang:master Jan 9, 2019
@compnerd compnerd deleted the placeholder-less branch January 9, 2019 00:23
finagolfin added a commit to finagolfin/swift that referenced this pull request Apr 8, 2020
…ig, so that it doesn't break

cross-compilation

Passing swift_core_private_link_libraries to PRIVATE_LINK_LIBRARIES only works either when
building a single host SDK alone or when needed by all SDKs, so move all that configuration
to a swift_core_private_libraries() function that's called from add_swift_target_library()
for each SDK/arch instead. Similarly, call a swift_runtime_static_libraries() function to
split off libraries for the static stdlib with linux. Finally, remove the last uses of
SWIFT_CONFIGURED_SDKS for anything more than checking, using SWIFT_SDKS instead, and move
the static-stdlib linker file generation to the stdlib/ directory.
finagolfin added a commit to finagolfin/swift that referenced this pull request Dec 11, 2021
…ig, so that it doesn't break

cross-compilation

Passing swift_core_private_link_libraries to PRIVATE_LINK_LIBRARIES only works either when
building a single host SDK alone or when needed by all SDKs, so move all that configuration
to a swift_core_private_libraries() function that's called from add_swift_target_library()
for each SDK/arch instead. Also, generate a static-executable-args.lnk for each ELF SDK,
rather than just for linux if it is the host SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant