Add swap binary operands code action#2694
Merged
Merged
Conversation
somiljain2006
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
June 18, 2026 14:38
Contributor
Author
ahoppen
reviewed
Jun 19, 2026
Contributor
Author
|
@ahoppen, can you review the updated changes? |
ahoppen
reviewed
Jul 2, 2026
ahoppen
left a comment
ahoppen
left a comment
Member
There was a problem hiding this comment.
Thank you. The results look good but I think the implementation can be simplified a bit. Left a few comments below.
ahoppen
reviewed
Jul 2, 2026
ahoppen
left a comment
ahoppen
left a comment
Member
There was a problem hiding this comment.
A couple small comments, otherwise looks good to me.
ahoppen
approved these changes
Jul 2, 2026
ahoppen
left a comment
ahoppen
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you @somiljain2006!
ahoppen
enabled auto-merge (squash)
July 2, 2026 14:20
Member
|
@swift-ci Please test |
Member
|
@somiljain2006 Would you be able to resolve the merge conflict introduced by #2671? |
auto-merge was automatically disabled
July 3, 2026 08:01
Head branch was pushed to by a user without write access
Contributor
Author
|
@ahoppen Done |
Member
|
@swift-ci Please test |
ahoppen
enabled auto-merge
July 3, 2026 08:11
Member
|
@swift-ci Please test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2520
Implement swap binary operands refactoring. Add a syntax-based code action that swaps the left and right operands of a binary expression when the cursor is positioned on the operator. Comparison operators are inverted as needed (for example,
<becomes>), while commutative operators are preserved. Add tests covering nested expressions, operator selection, unsupported operators, and trivia preservation.