Revert the matrix skipping changes#234
Conversation
The current technique results in error annotations in the actions UI and build badges to be red, despite appearing to otherwise work. It seems that GitHub Actions truly has no way to prevent the unevaluated matrix titles from showing up in results without side effects, so just go back to the original strategy of using `if`. Closes swiftlang#218
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
Fine with reverting this. I am working on writing up a plan how could unify the NIO and swiftlang workflows which would solve this issue as well.
|
@FranzBusch literally everything I tried could not work around the "ghost" jobs showing up for empty matrices (without side effects like the error annotations), can you elaborate on how you solved this? |
|
NIO workflows employ a two step mode. They have one job that generates a matrix which is then passed to another job that uses that matrix to configure itself. You can see it at play in a run like this https://github.com/apple/swift-nio/actions/runs/21933616664/job/63342800128 |
|
Can we merge this, while working on a proper solution as suggested by Franz ? |
4 participants
The current technique results in error annotations in the actions UI and build badges to be red, despite appearing to otherwise work. It seems that GitHub Actions truly has no way to prevent the unevaluated matrix titles from showing up in results without side effects, so just go back to the original strategy of using
if.Closes #218