Skip to content

Remove Context, use Logger everywhere #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianfett merged 1 commit into from
Jul 3, 2023
Merged

Remove Context, use Logger everywhere #70

fabianfett merged 1 commit into from
Jul 3, 2023

Conversation

@fabianfett
Copy link
Member

@fabianfett fabianfett commented Jul 3, 2023 •
edited
Loading

We have an internal typealias Context = Logging.Logger. This is quite confusing. Remove the typealias use logger naming everywhere instead.

@fabianfett
Remove Context use Logger name everywhere
660a7bf 
We have an internal typealias `Context = Logging.Logger`. Remove the typealias use logger naming everywhere instead.
@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Jul 3, 2023
@fabianfett fabianfett requested a review from Joannis July 3, 2023 09:53
@fabianfett fabianfett changed the title Remove Context use Logger name everywhere Remove Context, use Logger everywhere Jul 3, 2023
@fabianfett fabianfett merged commit 3001e41 into swift-server:main Jul 3, 2023
@fabianfett fabianfett deleted the ff-remove-context branch July 3, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Joannis Joannis Joannis approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabianfett @Joannis