feat(scheduler): 任务级参考图 labels + jitter 顶层契约 — image_ref_labels/jitter_minutes 全链路 (PR-B5)#157
Merged
Merged
Conversation
…r_minutes 全链路
NewJobBody/EditJobBody/JobOut 新增可选顶层字段 image_ref_labels / jitter_minutes；
_compose_metadata 用显式赋值让顶层字段权威覆盖 metadata 旧值（None 时不覆盖）；
_validate_qzone_daily 校验 label 形状([a-z0-9_-]{1,64})+数量≤8、jitter 0-180 → 422；
JobOut 从 metadata 读回回显；PATCH 合并透传，jitter 变更经 _apply_enabled_state
重建 runner loop 的 jitter_secs（复用 #155 _jitter_secs_from_metadata）。
builtin 组 system prompt 时读 image_ref_labels，在普通/多样性两种 tail 后追加
参考图指令段（best-effort，形状不对即省略，永不抛）。
上传通道复用现有 persona-asset 路由(kind=reference)，调度侧只存 label 字符串。
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
codex:needs-review
github-actions
Bot
added
the
status: ✅ merge-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-B5：定时任务级参考图 labels + jitter 的后端 API 契约
把
image_ref_labels/jitter_minutes提升为调度任务 API 的顶层字段，打通前端（#151/#154 已备好线型与组件）→ builtin 的链路。基于 #155 多样性引擎（_jitter_secs_from_metadata/QZONE_DAILY_DIVERSITY_TAIL已在），本 PR 只做衔接。改动
infra/_scheduler_lib.pyNewJobBody/EditJobBody/JobOut新增可选顶层字段image_ref_labels: list[str] | None、jitter_minutes: int | None（默认None，契约安全）。_compose_metadata：两个 B5 字段用显式赋值（非setdefault）写进 job metadata——顶层字段权威覆盖 metadata 里的旧值；顶层为None时不覆盖既有 metadata 值（这正是 PATCH 省略字段不丢的机制）。_validate_qzone_daily：labels 每个过资产 label 形状校验（_ASSET_LABEL_RE = [a-z0-9_-]{1,64}，对齐routes_admin_a/studio/_personas_lib.py::_LABEL_PATTERN）且数量 ≤8（_MAX_IMAGE_REF_LABELS，对齐corlinman_agent.image.dispatch._MAX_REFS）；jitter_minutes限0..180（_JITTER_MINUTES_MAX）。违规回 422invalid_qzone_daily_args。JobOut序列化经新_read_image_ref_labels/_read_jitter_minutes从 metadata 读回回显（防御式：形状不对→None）。_set_enabled_routeresume 再校验、_load_template_body模板解析都透传两字段。infra/scheduler.py（PATCHedit_job）jitter_minutes经_store_job→_apply_enabled_state→_register_runtime_loop自动用_jitter_secs_from_metadata(rj.metadata)重建 runner loop 的jitter_secs（与 feat(scheduler): QZone 日常发布多样性引擎 — 灵感种子 / 反重复 post-log / 多样性 tail / 发布抖动 (PR-B4) #155 读法一致，未额外造轮子）。scheduler/builtins/qzone_daily.py_resolve_image_ref_labels(metadata)读非空list[str]；_compose_image_ref_block渲染参考图指令段。_compose_system_prompt在普通 tail 与多样性 tail 之后都追加该段："如需配图：image_with_refs 的 characters 必须用这些参考图标签：{labels}；画面要像随手拍的生活切片而非摆拍合影。" best-effort，形状不对即省略，builtin 永不抛。上传通道（读过、无需改动）
参考图走现有 persona-asset 路由
routes_admin_a/studio/personas.py（POST表单kind="reference"，label过_validate_label→[a-z0-9_-]{1,64}）。image_with_refs（corlinman_agent/image/dispatch.py）已按 label 解析characters（_MAX_REFS=8截断）。调度侧只存 label 字符串，无需新端点。JobOut 回显语义（顶层 vs metadata 的权威关系）
_compose_metadata显式写入 metadata（覆盖旧值）；顶层None→ 保留 metadata 现值。JobOut.image_ref_labels/jitter_minutes从 metadata 读回。因此 PATCH 未传的字段不丢（metadata 里的值原样回显）。测试
test_admin_scheduler_qzone.py：POST 带 labels+jitter → JobOut 回显 + metadata 落库 + list 端点往返；无字段→回显null；PATCH 改 labels（jitter/persona 不丢）；PATCH 只改 jitter（labels 不丢）；9 label→422；"Bad Label!"→422；jitter=999→422；负数→422；PATCH 坏 label→422 且不 mutate。tests/scheduler/test_qzone_daily.py：两种 tail 后都带参考图段（含指定 labels 字面 + "随手拍的生活切片"）；无 labels 不含该段；_resolve_image_ref_labels防御式清洗；builtin 端到端 prompt 携带 metadata labels。验证
uv run ruff check（改动文件干净；仓库内唯一 ruff 报错在未触及的config_admin/models.py，base HEAD 即存在的既有债）uv run mypy python/packages/全绿（609 files）uv run lint-imports2 kept / 0 brokenenv -u ANTHROPIC_BASE_URL uv run pytest .../test_admin_scheduler_qzone.py .../tests/scheduler/ -q→ 166 passed与规格的偏差
无功能偏差。补充项：
_load_template_body与_set_enabled_route也透传/再校验两字段（规格未明列，为契约一致性顺带覆盖，低风险）。