Merged
Conversation
…is not a special keyword, and that looping through a string has the effect of iterating over its characters, while looping through a list iterates through its members. Thus, it's not a fact of 'char' that selects and iterates over characters.
Contributor
|
Thank you for your suggestions! I agree that the loop callout is helping understand the loops better. I think having both np and numpy imported is a bit confusing. Instead I suggest to say something along the lines that if they work with other people's code it is good to agree on the convention. |
Contributor
|
I modified the final commit and merged your PR. Thanks! |
maxim-belkin
pushed a commit
that referenced
this pull request
Jun 19, 2018
Move CODE_OF_CONDUCT.md to boilerplate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional callout for arbitrary loop variable names, and importing numpy as is, and as np.