fix(register): fix esm entry resolver for third-party executer, close #762#766
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 069b289 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yeliex
force-pushed
the
fix/specifer-format
branch
from
354f60b to
cb31ec4
Compare
Contributor
Author
|
@Brooooooklyn @martinslota please take a look |
martinslota
reviewed
Apr 8, 2024
martinslota
left a comment
martinslota
left a comment
There was a problem hiding this comment.
I can confirm that with startsWith instead of endsWith this addresses #762.
yeliex
added a commit
to yeliex/swc-node
that referenced
this pull request
Apr 10, 2024
…wc-project#762 (swc-project#766) * fix(register): fix esm entry resolver for third-party executor, close swc-project#762 * Create great-goats-trade.md * fix: bug fix
|
@Brooooooklyn Could you cut a release for this PR? |
tsang-bot Bot
referenced
this pull request
in tsangste/nx-package-test
May 5, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@swc-node/register](https://togithub.com/swc-project/swc-node) | [`1.9.0` -> `1.9.1`](https://renovatebot.com/diffs/npm/@swc-node%2fregister/1.9.0/1.9.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>swc-project/swc-node (@​swc-node/register)</summary> ### [`v1.9.1`](https://togithub.com/swc-project/swc-node/releases/tag/%40swc-node/register%401.9.1) [Compare Source](https://togithub.com/swc-project/swc-node/compare/@swc-node/[email protected]...@swc-node/[email protected]) #### What's Changed - fix: esm module resolve issues by [@​yeliex](https://togithub.com/yeliex) in [https://github.com/swc-project/swc-node/pull/754](https://togithub.com/swc-project/swc-node/pull/754) - fix: add default tsconfig.baseUrl to align with tsc behavior by [@​yeliex](https://togithub.com/yeliex) in [https://github.com/swc-project/swc-node/pull/759](https://togithub.com/swc-project/swc-node/pull/759) - fix(register): fix esm entry resolver for third-party executer, close [#​762](https://togithub.com/swc-project/swc-node/issues/762) by [@​yeliex](https://togithub.com/yeliex) in [https://github.com/swc-project/swc-node/pull/766](https://togithub.com/swc-project/swc-node/pull/766) - fix: support compile js files. close [#​761](https://togithub.com/swc-project/swc-node/issues/761) by [@​yeliex](https://togithub.com/yeliex) in [https://github.com/swc-project/swc-node/pull/767](https://togithub.com/swc-project/swc-node/pull/767) - chore: upgrade dependencies by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/swc-project/swc-node/pull/771](https://togithub.com/swc-project/swc-node/pull/771) **Full Changelog**: https://github.com/swc-project/swc-node/compare/[@​swc-node/register](https://togithub.com/swc-node/register)[@​1](https://togithub.com/1).8.0...[@​swc-node/register](https://togithub.com/swc-node/register)[@​1](https://togithub.com/1).9.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC42IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: tsang-bot[bot] <146107447+tsang-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third-party executors like mocha, may import scripts with fileUrl absolute path.
This pr converts
specifierfrom fileUrl to path.close #762