fix: fix import ts from node_modules by yeliex · Pull Request #744 · swc-project/swc-node

yeliex · 2023-12-02T15:15:02Z

as #727 (review) describes, when import .ts files from node_moduels, it throws error TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts".

it works well in 1.6.7

example scene: monorepo import .ts file in project, or server framework wants dynamic load routes in development

yeliex · 2023-12-07T06:29:34Z

@Brooooooklyn please take a look

weyert · 2024-01-04T19:56:02Z

Yes, would be nice if this change can be merged.

charleslai2000

I think this code can be changed into:

const TS_EXTENSIONS = [ts.Extension.Ts, ts.Extension.Tsx, ts.Extension.Mts];
const JS_EXTENSIONS = ["js", "jsx", "cjs", "mjs"];

export const resolve = async (specifier, context, nextResolve) => {
    const isTS = TS_EXTENSIONS.some((ext) => specifier.endsWith(ext));
    const isJS = JS_EXTENSIONS.some((ext) => specifier.endsWith(ext));
    // entrypoint
    if (!context.parentURL) {
        return {
            format: isTS ? 'ts' : undefined,
            url: specifier,
            shortCircuit: true,
        };
    }
    // import/require javascript module
    if (isJS) {
      // - local project non-TS file
      return nextResolve(specifier);
    }
    const { resolvedModule } = ts.resolveModuleName(specifier, fileURLToPath(context.parentURL), tsconfig, host, moduleResolutionCache);
    // import from local project to local project TS file
    if (resolvedModule && TS_EXTENSIONS.includes(resolvedModule.extension)) {
        return {
            format: 'ts',
            url: pathToFileURL(resolvedModule.resolvedFileName).href,
            shortCircuit: true,
        };
    }
    // import from local project to either:
    // - something TS couldn't resolve
    // - external library
    return nextResolve(specifier);
};

This code will deal with soft links of monorepo subprojects under node_modules, in this cache, the specifier has no extension at all.

charleslai2000 · 2024-03-02T09:13:12Z

In order to load typescript file under node_modules, you also need change file register.js, remove the following codes:

    if (options.files && options.files.length) {
        if (PLATFORM === 'win32' &&
            options.files.every((file) => filename !== (0, path_1.resolve)(process.cwd(), file))) {
            return sourcecode;
        }
        if (PLATFORM !== 'win32' && options.files.every((file) => !filename.endsWith(file))) {
            return sourcecode;
        }
    }

These codes will limit only compile files in current project and all ts files under node_modules will be filtered out and emit to node. This is not suitable in this context.

yeliex · 2024-03-02T10:39:16Z

I think this code can be changed into:

const TS_EXTENSIONS = [ts.Extension.Ts, ts.Extension.Tsx, ts.Extension.Mts];
const JS_EXTENSIONS = ["js", "jsx", "cjs", "mjs"];

export const resolve = async (specifier, context, nextResolve) => {
    const isTS = TS_EXTENSIONS.some((ext) => specifier.endsWith(ext));
    const isJS = JS_EXTENSIONS.some((ext) => specifier.endsWith(ext));
    // entrypoint
    if (!context.parentURL) {
        return {
            format: isTS ? 'ts' : undefined,
            url: specifier,
            shortCircuit: true,
        };
    }
    // import/require javascript module
    if (isJS) {
      // - local project non-TS file
      return nextResolve(specifier);
    }
    const { resolvedModule } = ts.resolveModuleName(specifier, fileURLToPath(context.parentURL), tsconfig, host, moduleResolutionCache);
    // import from local project to local project TS file
    if (resolvedModule && TS_EXTENSIONS.includes(resolvedModule.extension)) {
        return {
            format: 'ts',
            url: pathToFileURL(resolvedModule.resolvedFileName).href,
            shortCircuit: true,
        };
    }
    // import from local project to either:
    // - something TS couldn't resolve
    // - external library
    return nextResolve(specifier);
};

This code will deal with soft links of monorepo subprojects under node_modules, in this cache, the specifier has no extension at all.

add another condition to detect js files is unnecessary. these would be coved by final case.

yeliex · 2024-03-02T10:42:58Z

In order to load typescript file under node_modules, you also need change file register.js, remove the following codes:
    if (options.files && options.files.length) {
        if (PLATFORM === 'win32' &&
            options.files.every((file) => filename !== (0, path_1.resolve)(process.cwd(), file))) {
            return sourcecode;
        }
        if (PLATFORM !== 'win32' && options.files.every((file) => !filename.endsWith(file))) {
            return sourcecode;
        }
    }
These codes will limit only compile files in current project and all ts files under node_modules will be filtered out and emit to node. This is not suitable in this context.

I think it works as expected. files should be added into options.files, or leaves the option empty. or please provide reproduction case it it has problem in your situation

fix: fix import ts from node_modules

29a1156

psychobolt mentioned this pull request Jan 8, 2024

feat: Improve performance of running TypeScript files psychobolt/vite-storybook-boilerplate#261

Closed

Brooooooklyn merged commit c4485ca into swc-project:master Feb 1, 2024

charleslai2000 reviewed Mar 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: fix import ts from node_modules#744

fix: fix import ts from node_modules#744
Brooooooklyn merged 1 commit into
swc-project:masterfrom
yeliex:master

yeliex commented Dec 2, 2023 •

edited

Loading

Uh oh!

yeliex commented Dec 7, 2023

Uh oh!

weyert commented Jan 4, 2024

Uh oh!

charleslai2000 left a comment •

edited

Loading

Uh oh!

charleslai2000 commented Mar 2, 2024

Uh oh!

yeliex commented Mar 2, 2024

Uh oh!

yeliex commented Mar 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

yeliex commented Dec 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yeliex commented Dec 7, 2023

Uh oh!

weyert commented Jan 4, 2024

Uh oh!

charleslai2000 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charleslai2000 commented Mar 2, 2024

Uh oh!

yeliex commented Mar 2, 2024

Uh oh!

yeliex commented Mar 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

yeliex commented Dec 2, 2023 •

edited

Loading

charleslai2000 left a comment •

edited

Loading