Skip to content

fix(register): respect SWCRC environment variable when running in async mode#715

Merged
Brooooooklyn merged 1 commit into
swc-project:masterfrom
bgdavidx:master
Aug 18, 2023
Merged

fix(register): respect SWCRC environment variable when running in async mode#715
Brooooooklyn merged 1 commit into
swc-project:masterfrom
bgdavidx:master

Conversation

@bgdavidx

Copy link
Copy Markdown
Contributor

The current @swc-node/register/esm loader does not respect the SWCRC environment variable. This is due to the condition for setting swcRegisterConfig only applying to the sync transform version.

This PR fixes that, and also fixes module being overridden by "commonjs" when SWCRC environment variable is specified, which causes files being transformed by register/esm to be loaded as CommonJS which causes errors such as these:

server  | file:///app/apps/backend/src/app.ts:2
server  | Object.defineProperty(exports, "__esModule", {
server  |                       ^
server  |
server  | ReferenceError: exports is not defined in ES module scope
server  |     at file:///app/apps/backend/src/app.ts.mjs:2:23
server  |     at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
server  |

@CLAassistant

CLAassistant commented Jun 28, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Brooooooklyn Brooooooklyn merged commit c6aa3f9 into swc-project:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants