Repository navigation
fix: forward answers to pending questions - #22
Merged
swapnildahiphale merged 2 commits intoSep 8, 2026
Merged
swapnildahiphale merged 2 commits into
swapnildahiphale merged 2 commits into
Conversation
swapnildahiphale
approved these changes
Sep 8, 2026
swapnildahiphale
left a comment
Owner
There was a problem hiding this comment.
Thanks for fixing this — the /answer false-success bug was real and this is a clean, well-scoped fix for #20.
Validated locally: merges cleanly onto current main (merge and rebase both work), ruff check on changed files passes, and the full sre-agent unit suite is green aside from 3 pre-existing Helm dependency test failures on main. Good to merge.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the simple-mode
/answerendpoint report success only after an executing session accepts the payload into a pendingAskUserQuestion.Type of Change
Related Issues
Closes #20
Changes Made
Testing
Test Plan
Testing Steps
/answerroute with a concurrent waiter and verified the exact payload and event signal.RuntimeErrorcontaining the old marker remains a server error instead of being translated to HTTP 409.grepon PATH).ruff checkandgit diff --check; both passed.main;ruff checkon changed files passed; 379 unit tests passed (+5 new), 3 pre-existing Helm template failures unrelated to this PR.Screenshots / Videos
Not applicable; this is an API behavior change.
Checklist
blackandrufffor Python; changed-file Ruff lint passes)mainAdditional Context
The no-pending condition now uses a dedicated
NoPendingQuestionError; unrelated runtime failures propagate normally.Deployment Notes