bug: expected PropType in Model ImmutablePureComponent should be a map, instead of OrderedMap#5914
Closed
tim-lai wants to merge 5 commits intoswagger-api:masterfrom
Closed
bug: expected PropType in Model ImmutablePureComponent should be a map, instead of OrderedMap#5914tim-lai wants to merge 5 commits intoswagger-api:masterfrom
tim-lai wants to merge 5 commits intoswagger-api:masterfrom
Conversation
shockey
approved these changes
Mar 14, 2020
Contributor
shockey
left a comment
There was a problem hiding this comment.
looks good, but please clean out the unrelated diff before merging!
| { | ||
| // empty row befor extensions... | ||
| !showExtensions ? null : <tr> </tr> | ||
| !showExtensions ? null : <tr><td> </td></tr> |
17 tasks
Contributor
Author
|
Closing this PR in favor of cleaner PR #5921 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed from
schema: ImPropTypes.orderedMap.isRequired,toschema: ImPropTypes.map.isRequiredMotivation and Context
Prior to this change, there exists a console error
How Has This Been Tested?
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests