Swagger ui redesign/add icon support#5380
Merged
shockey merged 104 commits intoswagger-api:faceliftfrom Jun 3, 2019
Merged
Conversation
…on-container / scheme-container
Swagger redesign/update colors
…ult-margins-padding Reset default text margins, Add updated spacing to information-container, scheme-container
…wager-ui-redesign/fonts-part-two
…ign/fonts-part-two # Conflicts: # src/style/_buttons.scss
…sign/add-icon-support # Conflicts: # src/core/components/models.jsx # src/style/_models.scss
shockey
suggested changes
Jun 3, 2019
Contributor
shockey
left a comment
shockey
left a comment
There was a problem hiding this comment.
LGTM aside from my one change request.
| } | ||
|
|
||
|
|
||
| // Fontello Icons |
Contributor
There was a problem hiding this comment.
Change request: add a comment that tells other folks how to regenerate this code (including any manual changes that were made to what Fontello generated).
Will come in handy when/if we need to add a new icon to the mix.
Contributor
|
Merging -- per conversation with @lshaw-sb, my change request will be addressed in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependant on PR #5379
Description
Adds font-awesome icons in woff format from fontello generated css file.
Includes an Icon component in layout-utils
Motivation and Context
Provides icons specified in swagger ui redesign spec
How Has This Been Tested?
Manually across browsers
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests