#4537 - Invalid HTML ID for Operations with tags which contain multiple words#4538
Merged
shockey merged 3 commits intoswagger-api:masterfrom Aug 23, 2018
Conversation
…tiple words in tags
This comment has been minimized.
This comment has been minimized.
shockey
approved these changes
Aug 23, 2018
Contributor
shockey
left a comment
There was a problem hiding this comment.
Approved with minor changes: using createDeepLinkPath directly on the element ID.
Contributor
|
tests forthcoming in another branch (waiting on #4827's resolution first). thanks, @ChristophWalter! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First Take a look at the bugticket #4537
This pull requests adapts the operation component to transform the tag name with help of the util function
createDeepLinkPath. This leads to a valid html id of the operation containers.Motivation and Context
Fixes #4537
How Has This Been Tested?
Manual testing with help of the developer tools. "Before" screenshots are attached to the bug ticket.
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests