Adds ability to set oauth2RedirectUrl using env vars for Docker#3280
Closed
shankie-codes wants to merge 3 commits intoswagger-api:masterfrom
Closed
Adds ability to set oauth2RedirectUrl using env vars for Docker#3280shankie-codes wants to merge 3 commits intoswagger-api:masterfrom
shankie-codes wants to merge 3 commits intoswagger-api:masterfrom
Conversation
`initOauth` was originally only available in the dev server. This commit makes it available in the dist server as well, and makes updates to `docker-run.sh` so that the variables in `initOauth` can be set using environment variables.
Contributor
|
@fehguy - when you get a chance... :) |
shockey
reviewed
Mar 3, 2018
Contributor
shockey
left a comment
shockey
left a comment
There was a problem hiding this comment.
I'm seeing some issues with Authorize button rendering in this branch, while testing with this definition: https://gist.githubusercontent.com/shockey/7587cca232341ea95766d22eb67ba11f/raw/3d44873d96fa5a8d184678a84c8464e4930869cd/openapi.yaml
Contributor
|
TODO: notify @webron upon resolution of this PR |
|
What's the status on this? This is a serious problem when using Swagger UI from Docker... |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #3138 , added ability to set oauth2RedirectUrl by setting env var
OAUTH2_REDIRECT_URL. Updated readme to better document the options available to Docker users.