Skip to content

SWG-7516 utilizing safeURLResolver in swagger-parser-v3#1911

Merged
MiloszTarka merged 7 commits intomasterfrom
SWG-7516-utilizing-safe-url-resolving-in-swagger-parser
Apr 24, 2023
Merged

SWG-7516 utilizing safeURLResolver in swagger-parser-v3#1911
MiloszTarka merged 7 commits intomasterfrom
SWG-7516-utilizing-safe-url-resolving-in-swagger-parser

Conversation

@MiloszTarka
Copy link
Copy Markdown
Contributor

@MiloszTarka MiloszTarka commented Apr 14, 2023

This PR makes swagger-parser-v3 to utilizes safeUrlResolver when resolving OpenAPI 3.1 definitions.

The reason behind this change is described deeply under the following PR:
#1910

The $refs are checked in ReferenceVisitor class, in readHTTP method.

@MiloszTarka MiloszTarka marked this pull request as ready for review April 17, 2023 08:21
Comment thread modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/OpenAPIV3Parser.java Outdated
Comment thread modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/OpenAPIV3Parser.java Outdated
Copy link
Copy Markdown
Contributor

@gracekarina gracekarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@CalemRoelofsSB CalemRoelofsSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants