OAS3: Style/Explode parameter serialization#1140
Merged
shockey merged 12 commits intoswagger-api:masterfrom Sep 29, 2017
Merged
OAS3: Style/Explode parameter serialization#1140shockey merged 12 commits intoswagger-api:masterfrom
shockey merged 12 commits intoswagger-api:masterfrom
Conversation
Contributor
Author
|
@webron, mostly looking for you to either sign off on this PR with the limitation mentioned above, or give guidance on how to go about implementing nested object support 😄 thanks! |
Contributor
|
Why do you hate me, @shockey. |
Contributor
|
Okay. If you followed the documentation in https://swagger.io/docs/specification/serialization, and made sure the default values mentioned there are taken into account when no value is explicitly provided, it should be fine. As for |
This was referenced Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
styleandexplodeallowReservedfunctionality, along with testsLimitations:
deepObjectdoes not handle nested objects. The specification and swagger.io documentation does not provide an example for serializing deep objects. Flat objects will be serialized into thedeepObjectstyle just fine.