Skip to content

Adding support for properties in ComposedModel#9827

Merged
frantuma merged 2 commits intomasterfrom
propertiesInComposedModel
Nov 12, 2019
Merged

Adding support for properties in ComposedModel#9827
frantuma merged 2 commits intomasterfrom
propertiesInComposedModel

Conversation

@gracekarina
Copy link
Copy Markdown
Contributor

@gracekarina gracekarina commented Nov 2, 2019

PR checklist

Branch: Master

Description of the PR

refs - swagger-api/swagger-parser/issues/1143 - Adding support for properties in ComposedModel
depends on swagger-api/swagger-parser#1241

@gracekarina gracekarina requested a review from frantuma November 2, 2019 21:57
@frantuma
Copy link
Copy Markdown
Contributor

please build

2 similar comments
@frantuma
Copy link
Copy Markdown
Contributor

please build

@frantuma
Copy link
Copy Markdown
Contributor

please build

@frantuma
Copy link
Copy Markdown
Contributor

please build

@frantuma
Copy link
Copy Markdown
Contributor

please build

@spacether
Copy link
Copy Markdown

spacether commented Nov 15, 2019

@gracekarina thank you for fixing this. On a related note
Additional properties should also be allowed in composed schemas, but that feature is blocked by a bug in swagger-parser swagger-api/swagger-parser#1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants