[Ruby] Global namespaces for ruby basic types#6418
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Sep 1, 2017
zhulik:patch-1
Merged
[Ruby] Global namespaces for ruby basic types#6418wing328 merged 1 commit intoswagger-api:masterfrom zhulik:patch-1
wing328 merged 1 commit intoswagger-api:masterfrom
zhulik:patch-1
Conversation
File here will be overriden by generated class File of swagger.yml containse the definition named File. Using global namespace can fix it
Contributor
|
Tests with updated Petstore passed via https://travis-ci.org/swagger-api/swagger-codegen/builds/270825165 |
Contributor
|
@zhulik thanks for the fix, which has been merged into master. |
wing328
changed the title
wing328
added a commit
that referenced
this pull request
Sep 1, 2017
…6421) * Revert "Make the Rust codegen compile. (#6411)" This reverts commit 60766c6. * Revert "[Kotlin] Fix model enum generation (#6383)" This reverts commit adf5d64. * Revert "Global namespaces for ruby basic types (#6418)" This reverts commit 070894d. * Revert "add ehyche to swift tech comm" This reverts commit 5c62ba1. * Revert "[python-client] Thread pool fix (#6396)" This reverts commit a28ce0b. * Revert "update retrofit2 petstore samples" This reverts commit 0f1a61d. * Revert "Retrofit2: Return ResponseBody if response if file. (#6407)" This reverts commit 481c040.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for breaking (non-backward compatible) changes.Description of the PR
File here will be overriden by generated class File if swagger.yml contains the definition named File. Using global namespace can fix it